[controller] Add StoreGrpcService for store related gRPC endpoints and reduce boilerplate #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d reduce boilerplate Add checkResourceCleanupForStoreCreation to gRPC Move create store to store grpc service
sushantmane
force-pushed
the
grpc-in-venice-control-plane-acl-apis
branch
from
e3f95cf to
7442860
Compare
2 tasks
KaiSernLim
approved these changes
Jan 23, 2025
.../src/integrationTest/java/com/linkedin/venice/controller/TestControllerSecureGrpcServer.java
Show resolved
Hide resolved
|
Thanks a lot, @KaiSernLim 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add StoreGrpcService and refactor gRPC server configuration
StoreGrpcServiceImplfor store-related gRPC endpoints (update, get, delete ACLs).VeniceUnauthorizedAccessExceptionto handle unauthorized access scenarios.VeniceGrpcServerConfigto support multipleBindableServiceinstances.VeniceGrpcServerto register multiple services and interceptors.StoreRequestHandlerto process store-specific gRPC requests.ControllerGrpcServerUtilsfor common gRPC request handling and error responses.StoreRequestHandlerand enhanced existing gRPC server tests.How was this PR tested?
UT and E2E tests
Does this PR introduce any user-facing changes?